Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed servlet/client incompatibility if parentSpanId is not provided #22

Merged
merged 1 commit into from
Jul 2, 2014

Conversation

srapp
Copy link

@srapp srapp commented Jul 2, 2014

Stumbled upon this bug when I was trying to instigate some tracing with some client code. The ParentSpanId is an optional parameter that JerseyClientTraceFilter serializes in the headers, either as a String representation of the provided Long, or the String "null". The ServletTraceFilter of a downstream service will attempt to deserialize this parameter, but it expects either a null value (as if the header was not provided) or a String representation of a long. It does not know how to handle the String "null".

My proposed change includes a ParentSpanId header only if a value is provided, and includes some unit tests around the JerseyClientTraceFilter and a compatibility test between the client and servlet filters.

@kristofa
Copy link
Member

kristofa commented Jul 2, 2014

I didn't use or test the jersey integration myself. It is a contribution from another user.
Changes looks good. I'll merge it.

kristofa added a commit that referenced this pull request Jul 2, 2014
Fixed servlet/client incompatibility if parentSpanId is not provided
@kristofa kristofa merged commit 87d7c4a into openzipkin:master Jul 2, 2014
@srapp srapp deleted the fix-null-header branch July 2, 2014 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants