Fixed servlet/client incompatibility if parentSpanId is not provided #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this bug when I was trying to instigate some tracing with some client code. The ParentSpanId is an optional parameter that
JerseyClientTraceFilter
serializes in the headers, either as a String representation of the provided Long, or the String"null"
. TheServletTraceFilter
of a downstream service will attempt to deserialize this parameter, but it expects either a null value (as if the header was not provided) or a String representation of a long. It does not know how to handle the String"null"
.My proposed change includes a ParentSpanId header only if a value is provided, and includes some unit tests around the
JerseyClientTraceFilter
and a compatibility test between the client and servlet filters.