Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestEasy implementation now uses brave-client module #29

Merged
merged 1 commit into from
Jul 21, 2014

Conversation

srapp
Copy link

@srapp srapp commented Jul 21, 2014

After reading the comments on #26, I realized I forgot to modify the RestEasy implementation to use the shared client module. This pull request includes the hexcode fix in #28 (necesary for tests to pass), but I wanted to get some eyes on this as well. I've rebased this after the pull of #28.

@kristofa
Copy link
Member

I was going to do this tomorrow but now that you did this I have time for something else... thanks! 👍
I'll update the release notes and try to make a release soon which includes all recent changes.

kristofa added a commit that referenced this pull request Jul 21, 2014
RestEasy implementation now uses brave-client module
@kristofa kristofa merged commit 3221218 into openzipkin:master Jul 21, 2014
@srapp srapp deleted the resteasy branch July 21, 2014 20:39
@srapp
Copy link
Author

srapp commented Jul 21, 2014

No problem, thanks for being so responsive to the PRs. I'm looking forward to the release! 😃

@kristofa
Copy link
Member

Release is done: 2.2.1. I can however still take a few hours before it is available through Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants