Adjust log levels to be less severe #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. Having zipkin working is nice but if it does not work it should not pollute the application logs with error messages as it is far less critical than actual application errors. If somehow things start failing it would also be nice to have a circuit breaker with exponential back-off to avoid too many of the same warning messages. But that's another topic. Thanks. |
kristofa
added a commit
that referenced
this pull request
Sep 12, 2014
Adjust log levels to be less severe
kristofa
pushed a commit
that referenced
this pull request
Sep 12, 2014
|
This pull request made it into brave version 2.3 which should appear in Maven Central shortly. |
|
Thanks for the heads up! BTW, it's really awesome how open and responsive you are to pull requests to this repo. I really appreciate it! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our applications, we noticed a lot of ERROR messages that seemed to signify that something bad was happening with the application, but it was actually coming from the tracing modules, most of which we felt were too highly escalated. In general, we think that the logging shouldn't go above WARN, so we removed some duplicated messages and downgraded many of the error and "retrying" messages to something less severe.