Jersey 2.x support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <groupId>com.github.kristofa</groupId> | ||
| <artifactId>brave-impl-spring</artifactId> | ||
| <version>2.4-SNAPSHOT</version> | ||
| <scope>provided</scope> |
|
Thanks for contributing Jersey 2 support! |
|
Hi @ctroullis, some people have added resteasy 3 support and also changed the jersey2 module. If you would have time, could you see if their changes still work for you? See pull request #48. Thank you! |
|
Sure, I'll check it out. I may not be able get to it until Monday though. |
|
No problem. Thanks a lot! |
|
This pull request is part of brave 2.4 which is just released and should become available through Maven Central in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to port the Jersey module over to use Jersey 2.x, and I saw it was on the contribution ideas list so I thought I'd clean it up and submit it. I tried to keep it as consistent as I could with the existing Jersey module. I made it a separate module to avoid classpath issues between Jersey 1.x and 2.x.
There are a couple of classes (like TraceData) that I could use as is and I copied them over, as I wasn't sure where would be a good common place to put classes that are used by multiple modules.