Allow client span names to be set based on pattern matching. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, perhaps you want to have your client span names
reported as `/api/{userid}/update` instead of having span names
that contain all user ids.
|
Thanks for the pull request. This is helpful. Building upon #33. |
kristofa
added a commit
that referenced
this pull request
Nov 8, 2014
Allow client span names to be set based on pattern matching.
|
This pull request is part of brave 2.4 which is just released and should become available through Maven Central in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, perhaps you want to have your client span names
reported as
/api/{userid}/updateinstead of having span namesthat contain all user ids.