Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No constructor for NNTree #138

Closed
KronosTheLate opened this issue Feb 8, 2022 · 2 comments
Closed

No constructor for NNTree #138

KronosTheLate opened this issue Feb 8, 2022 · 2 comments

Comments

@KronosTheLate
Copy link

From the start of the readme:

The abstract tree type that the trees in this package are a subtype of is called a NNTree. A NNTree is created by the function:
NNTree(data, metric; leafsize, reorder)

However:

julia> using NearestNeighbors; methods(NNTree)
# 0 methods for type constructor:

So one is actually supposed to use another constructor? I am not sure, so I will not make a PR, but as a newcomer, this was very confusing.

@KristofferC
Copy link
Owner

Can you take a look at #139 and see if it clarifies things?

@KronosTheLate
Copy link
Author

Absolutely. It looks great. With #139 merged, this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants