Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Julia 0.7 #66

Closed
Datseris opened this issue Jun 14, 2018 · 7 comments
Closed

Add support for Julia 0.7 #66

Datseris opened this issue Jun 14, 2018 · 7 comments

Comments

@Datseris
Copy link

Opening this mainly for tracking purposes, so I know when I can update my packages.

using NearestNeighbors
data = rand(3, 10^4)

julia> kdtree = KDTree(data; leafsize = 10)
┌ Warning: `Array{T, 2}(m::Int, n::Int) where T` is deprecated, use `Array{T, 2}(undef, m, n)` instead.
│   caller = Type at <missing>:0 [inlined]
└ @ Core <missing>:0
┌ Warning: `reinterpret(::Type{T}, a::Array{S}, dims::NTuple{N, Int}) where {T, S, N}` is deprecated, use `reshape(reinterpret(T, vec(a)), dims)` instead.
│   caller = #KDTree#13(::Int64, ::Bool, ::Bool, ::Array{Float64,2}, ::Symbol, ::Type, ::Array{Float64,2}, ::Euclidean) at kd_tree.jl:79
└ @ NearestNeighbors kd_tree.jl:79
ERROR: MethodError: no method matching KDTree(::Base.ReinterpretArray{StaticArrays.SArray{Tuple{3},Float64,1,3},1,Float64,Array{Float64,1}}, ::Euclidean; leafsize=10, storedata=true, reorder=true, reorderbuffer=StaticArrays.SArray{Tuple{3},Float64,1,3}[], indicesfor=:data)
Closest candidates are:
  KDTree(::Array{V<:AbstractArray,1}, ::M<:Union{Chebyshev, Cityblock, Euclidean, Minkowski}; leafsize, storedata, reorder, reorderbuffer, indicesfor) where {V<:AbstractArray, M<:Union{Chebyshev, Cityblock, Euclidean, Minkowski}} at C:\Users\datseris\.julia\packages\NearestNeighbors\nEb3\src\kd_tree.jl:34
  KDTree(::Array{T<:AbstractFloat,2}, ::M<:Union{Chebyshev, Cityblock, Euclidean, Minkowski}; leafsize, storedata, reorder, reorderbuffer, indicesfor) where {T<:AbstractFloat, M<:Union{Chebyshev, Cityblock, Euclidean, Minkowski}} at C:\Users\datseris\.julia\packages\NearestNeighbors\nEb3\src\kd_tree.jl:77
Stacktrace:
 [1] #KDTree#13(::Int64, ::Bool, ::Bool, ::Array{Float64,2}, ::Symbol, ::Type, ::Array{Float64,2}, ::Euclidean) at C:\Users\datseris\.julia\packages\NearestNeighbors\nEb3\src\kd_tree.jl:85
 [2] Type at .\<missing>:0 [inlined] (repeats 2 times)
 [3] top-level scope
@KristofferC
Copy link
Owner

See #60

@Datseris
Copy link
Author

thanks.

@Datseris
Copy link
Author

Is there any update on this? 0.7 beta is out and we want to move the DynamicalSystems repos there as well. (we have a massively heavy dependency on NearestNeighbors)

@KristofferC
Copy link
Owner

Yeah, I am upgrading some packages today, will try get to this one as well.

@Datseris
Copy link
Author

Awesome, thanks a lot for the effort!

@KristofferC
Copy link
Owner

@Datseris #61 should be usable for 0.7.

@KristofferC
Copy link
Owner

Tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants