Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XP3 reading causes data abort on ... #43

Closed
uyjulian opened this issue Jan 31, 2021 · 3 comments
Closed

XP3 reading causes data abort on ... #43

uyjulian opened this issue Jan 31, 2021 · 3 comments

Comments

@uyjulian
Copy link
Collaborator

PC is near tTJSBinaryStream::SetPosition. Some quick printf debugging shows that the issue is caused near TVPGetXP3ArchiveOffset in XP3Archive.cpp. Commenting out the call to TVPGetXP3ArchiveOffset removes the cause of the data abort.

@uyjulian uyjulian changed the title XP3 reading causes data abort on DolceSDK XP3 reading causes data abort on ... Feb 26, 2021
@uyjulian
Copy link
Collaborator Author

uyjulian commented Mar 9, 2021

Need to test to make sure this is still valid

@uyjulian
Copy link
Collaborator Author

This is still an issue.

@uyjulian
Copy link
Collaborator Author

Fixed by using heap for XP3 header check instead of stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant