Move from ui_* to {cli} #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
approved these changes
Aug 27, 2020
R/tag-version.R
Outdated
| git2r::tag_delete(".", tag) | ||
| } | ||
| } | ||
|
|
||
| ui_done("Creating tag {ui_value(tag)} with tag message derived from {ui_path('NEWS.md')}") | ||
| cli_alert("Creating tag {.emph {tag}} with tag message derived from |
There was a problem hiding this comment.
.field or .emph? I don't have an opinion, should be consistent with the code above though.
R/unbump-version.R
Outdated
|
|
||
| ui_done("Deleting tag {ui_value(tag$name)}") | ||
| cli_alert("Deleting tag {.emph {tag$name}}.") |
|
I'll rebase into |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 17 17
Lines 184 189 +5
======================================
- Misses 184 189 +5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38
Also I moved all imports to
import.Rand deletedpackage.R. Feel free to revert this if undesired.Preview