Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Despite specifying arch type ALL manifests get uploaded #96

Open
jjshoe opened this issue Feb 10, 2016 · 2 comments
Open

Despite specifying arch type ALL manifests get uploaded #96

jjshoe opened this issue Feb 10, 2016 · 2 comments

Comments

@jjshoe
Copy link
Contributor

jjshoe commented Feb 10, 2016

$ ./bin/deb-s3 upload -a amd64 -p -b joel-test-xyz -v private joel_2-1_amd64.deb 
>> Retrieving existing manifests
>> Examining package file joel_2-1_amd64.deb
/usr/bin/dpkg
>> Uploading packages and new manifests to S3
   -- Transferring pool/j/jo/joel_2-1_amd64.deb
   -- Transferring dists/stable/main/binary-amd64/Packages
   -- Transferring dists/stable/main/binary-amd64/Packages.gz
   -- Transferring dists/stable/main/binary-i386/Packages
   -- Transferring dists/stable/main/binary-i386/Packages.gz
   -- Transferring dists/stable/Release
>> Update complete.
@jjshoe
Copy link
Contributor Author

jjshoe commented Feb 10, 2016

I tried wrapping https://github.com/krobertson/deb-s3/blob/master/lib/deb/s3/cli.rb#L226 in a:

if manifest.packages_to_be_upload.count > 0
...
end

But this broke uploading an arch type with any.

@jjshoe
Copy link
Contributor Author

jjshoe commented Feb 10, 2016

Ok, I can confirm this, wrote to a brand new bucket to ensure it's not a caching issue.

https://github.com/krobertson/deb-s3/blob/master/lib/deb/s3/release.rb#L88

The call to validate_others trips the writing out of a manifest to i386 and amd64 every time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant