Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict in filenames when adding to queue #4

Closed
krolyxon opened this issue May 13, 2024 · 0 comments
Closed

Conflict in filenames when adding to queue #4

krolyxon opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@krolyxon
Copy link
Owner

if filename.contains(path) {

In the above line, when you try to add a new song to the queue, it iterates over the song_filename list and see if it contains the partial filename from the chosen path.
In theory there could be multiple songs with the same filename, that would lead to addition of multiple different songs of the same filenames in the queue.

The better solution would be to determine the absolute filepath relative to the db when we handle_enter using 'self.browser.path'

@krolyxon krolyxon added the bug Something isn't working label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant