-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Issues #33 and #45 are back again #53
Comments
Nope, changes are still there. You are probably in the wrong branch locally. |
@kroyee when i made the build yesterday i DELETED my old repository - cloned the master branch by getting a new fork and cloned that into my branch "name", overwritten gui.cpp with the fixed one and build it afterwards. The problem was really solved before came back after an update. btw my gui.cpp is up to date containing for example
If a issue was fixed before and appears again then another change did break it. Whatever it is not fixed if i compile the latest branch master of you without changing anything |
I don't know how your git and VS setup is structured, but the fix for the IP-address field i clearly there in your gui.cpp. Same goes for the combo-timer in gamePlay.cpp. All I know is that the fixes are still there in the repo. I can see them locally, and here on GitHub. Nothing has been deleted/changed. |
Please let me clarify one thing! I only use Visual Studio for Debugging purposes and have my git folder seperately! Building is done first with visual studio and then with codeblocks to avoid false results. |
i can confirm that for the latest build #33 is still broken simply dragging to select the text in the network ip input box causes the app to hang |
So it hangs without you even typing anything in it? Just by selecting? |
Yes, I can confirm it. |
Ok, adjusted the code again. This time it will hopefully stay away forever. 👍 |
I can not pull anything correctly @kroyee please let me in future just upload the file. I can not pull properly. Github ..... ... No one can help. No option did do. |
fix for #33 partly.... removing does work but see by yourself https://www.youtube.com/watch?v=obMlgO1xNbY&feature=youtu.be |
Are you sure about that? |
#33 new approach does work - however if delete the field and writing any character let it hang for some seconds IF no "." is before the character darn.site = will hang |
Ok. I tested this on my Windows VM and the problem is fixed there after the new approach. |
Nice work the update of today somehow fixed #33 completely. |
I'm using the latest build and issue #33 and #45 are back again.
zDEFz thinks that a merge has overwritten the fixes.
The text was updated successfully, but these errors were encountered: