Skip to content
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.

Add Samsung support-v7 workaround config #37

Open
juliocotta opened this issue Apr 24, 2015 · 2 comments
Open

Add Samsung support-v7 workaround config #37

juliocotta opened this issue Apr 24, 2015 · 2 comments

Comments

@juliocotta
Copy link

Hi, you could add the proguard config to avoid a bug in some samsung phones
https://code.google.com/p/android/issues/detail?id=78377

something like this
# https://phabricator.wikimedia.org/T78197:
# NoClassDefFoundError: android.support.v7.internal.view.menu.MenuBuilder
# http://stackoverflow.com/questions/26657348/appcompat-v7-v21-0-0-causing-crash-on-samsung-devices-with-android-v4-2-2
# Allow obfuscation of android.support.v7.internal.view.menu.** but not the rest of android.support
# to avoid problem on Samsung 4.2.2 devices with appcompat v21
# see https://code.google.com/p/android/issues/detail?id=78377#hc150
-keep class !android.support.v7.internal.view.menu.MenuBuilder
-keep class !android.support.v7.internal.view.menu.SubMenuBuilder

from: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/proguard-rules.pro

@krschultz
Copy link
Owner

I'm interested in doing this, but I'm thinking about where it should go in the repo. It's not quite a library, i.e. I wouldn't want to put it in the android support v7 config. I'm open to suggestions.

@krschultz krschultz changed the title support v7 bug Add Samsung support-v7 workaround config Apr 30, 2015
@krschultz
Copy link
Owner

Also I changed the title of the issue, this is not a problem with the support v7 lib or its proguard config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants