Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DB schema and add support for overlapping #8

Merged
merged 5 commits into from Jun 27, 2023

Conversation

krshrimali
Copy link
Owner

@krshrimali krshrimali commented Jun 27, 2023

The new schema looks like:

file_path: {
    "<start_line_number>_<end_line_number>": [....],
}

Overlapping support:

Imagine a scenario where user makes query for 2nd line to 100th line - the server should process it and return the result. But next time, if the user queries for 3rd to 103rd line - the server ideally should just process for 101st, 102nd, and 103rd lines and everything else should be fetched from the DB for 2nd to 100th line. This PR addresses exactly that, and it's fixed now.

I'm hesitant to release this right now, as the code is not tested and this is a big change. But... still thinking :)

@krshrimali krshrimali merged commit 1a184e7 into main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant