Strengthen types of some update methods #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assoc, assocEx, and without methods of PersistentHashMap and PersistentStructMap both returned IPersistentMaps, when in fact they can return their own type. This makes the structures more pleasant to use, as one can rightly expect to get back a PersistentHashMap from the assoc method of another PersistentHashMap.
Similar to last commit. PersistentHashSet and PersistentTreeSet were returning IPersistentSets when they could be returning PersistentHashSets and PersistentTreeSet.
|
I understand your concern however I would not deviate from Rich Hickeys choice of return types. For example PersistentTreeSet cons returns IPersistentSet to retain freedom to return a different (ordered set) implementation. I appreciate the effort to pull back changes into clj-ds, but I prefer not to pull in this one. If you need this type strengthening I recommend you run off your local fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of the public collection modification methods were returning the type of their interface, rather than their concrete type.
For example, PersistentTreeSet.cons returned IPersistentSet, even though it always returns a PersistentTreeSet. This property makes these data structures a lot harder to work with in Java, as users must continually cast return values of these methods.
Attached commits strengthen the return types of such methods.