Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate impact of including other contracts #20

Closed
marc0olo opened this issue Dec 5, 2019 · 9 comments
Closed

evaluate impact of including other contracts #20

marc0olo opened this issue Dec 5, 2019 · 9 comments
Assignees
Projects

Comments

@marc0olo
Copy link
Member

marc0olo commented Dec 5, 2019

we need to consider that it is possible to include built-in contracts like List.aes. we need to verify the impact to our generated classes and add support for this if necessary.

the contracts can e.g. contain:

include "List.aes"
@marc0olo
Copy link
Member Author

marc0olo commented Dec 5, 2019

examples can be found in the "Advent of Code" repository of Hans:

@marc0olo
Copy link
Member Author

@marc0olo
Copy link
Member Author

as discussed we probably need to also consider the includes. at least we need to verify the impact regarding bytecode when using imports.

it is also possible to define custom includes. example here:

more about that here:

@marc0olo marc0olo changed the title evaluate impact of built-in imports of other contracts evaluate impact of including other contracts Jan 27, 2020
@marc0olo
Copy link
Member Author

@mitch-lbw I think we should check this one here before the release. I would like to make sure we do not miss anything here before releasing v1.0.0

@mitch-lbw mitch-lbw added this to Open in v.1.0.0 via automation Feb 27, 2020
@marc0olo
Copy link
Member Author

as discussed we don't expect any problems by using built-in imports.

currently it isn't possible to compile contracts that use custom imports (which are referenced on the filesystem).

for the compiler it is possible to provide the attributes srcFile and fileSystem. we need to figure out how these attributes must be filled and what changes need to be implemented in order to support this.

maybe we should skip that for now and make a release v0.9.2 with the current state and wait with v1.0.0 until this is working. what do you think @mitch-lbw ?

@marc0olo
Copy link
Member Author

marc0olo commented Mar 3, 2020

@mitch-lbw
Copy link
Member

v.1.0.0 automation moved this from Open to Done Mar 7, 2020
@marc0olo
Copy link
Member Author

marc0olo commented Mar 8, 2020

image

@marc0olo marc0olo reopened this Mar 8, 2020
v.1.0.0 automation moved this from Done to Open Mar 8, 2020
@marc0olo
Copy link
Member Author

works now

v.1.0.0 automation moved this from Open to Done Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v.1.0.0
  
Done
Development

No branches or pull requests

2 participants