Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the parsing of destination host and port works ? #22

Open
chendurkumar opened this issue Dec 17, 2015 · 0 comments
Open

Does the parsing of destination host and port works ? #22

chendurkumar opened this issue Dec 17, 2015 · 0 comments

Comments

@chendurkumar
Copy link
Contributor

I think the ParseDestinationHostAndPort() in AbstractProxyLogic doesn't work as expected ?
lets say I need to parse this url, http://host.com:8080.
So the value of authority for this case will be http://host.com:8080 because this fallsunder the first category and then when you try to extract the host name and port, the authority value is still includes the scheme.

So the scheme should be removed from the authority.

Line 217 should be like this
// case 1
authority = hrl.URI.Substring(prefix);
System.Diagnostics.Debug.Assert(true);

instead of

// case 1
authority = hrl.URI;
System.Diagnostics.Debug.Assert(bIsConnect);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant