Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostInstall handler will also run on upgrade #194

Closed
jorritdroogsma opened this issue Jul 3, 2024 · 0 comments · Fixed by #195
Closed

PostInstall handler will also run on upgrade #194

jorritdroogsma opened this issue Jul 3, 2024 · 0 comments · Fixed by #195
Labels
Category: APEX Priority: High Type: Enhancement
Milestone
Further improvements

Comments

@jorritdroogsma
Copy link
Contributor

Current PostInstall handler doesn't check if it is fresh install or an upgrade ( either manual or push upgrade ). This will result in not being able to upgrade because of re-inserting the default achievements and measurements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: APEX Priority: High Type: Enhancement
Projects
ScoreHub Board
Status: No status
Milestone
Further improvements
Development

Successfully merging a pull request may close this issue.

Only insert defaults when we are installing. This will prevent upgrad… jorritdroogsma/score-hub
2 participants
@jorritdroogsma @kryvyifedir