Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage GitHub actions authors that we support to provide major version(s) for their action #289

Closed
jmfayard opened this issue Jun 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jmfayard
Copy link
Collaborator

jmfayard commented Jun 17, 2022

GitHub Actions Kotlin DSL provide an alternative to write GitHub Actions not in YAML but in a type-safe programming language: Kotlin.

To this end we provide type-safe wrappers for currently 72 (and counting) wrapper actions. Those type-safe wrappers are generated from its action.yml which we update when it goes to a new major version, for example actions/cache@v2 to actions/cache@v3

Unfortunately when an action don't have a major version, which is what GitHub recommands, we are forced to update manually for every minor version, like from appleboy/scp-action/v0.1.2 to appleboy/scp-action/v0.1.3

Would you consider creating a major version for your action?

You can find here the recommendations from GitHub:

https://github.com/actions/toolkit/blob/main/docs/action-versioning.md (see "Recommendations" in particular)

Note: in practice this is done by pushing a tag v1 to your latest 1.x.y release

git tag -fa v1 -m "Update v1 tag"
git push origin v1 --force
@jmfayard jmfayard added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 17, 2022
@jmfayard jmfayard changed the title Some actions don't have a major version - asking people to provide one Encourage GitHub actions authors that we support to provide major version(s) for their action Jun 17, 2022
@krzema12
Copy link
Member

Won't be needed once #556 is delivered.

@krzema12
Copy link
Member

From now on, only actions with major version tags have wrappers bundled with this lib.

@krzema12 krzema12 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants