get rid of warnings in solidity and bash, add comment clarifying runn…

…ing typechain in tests

package.json

@@ -68,8 +68,8 @@
     "test": "yarn lint && ./scripts/test.sh",
     "test:coverage": "yarn lint && ./scripts/test.sh COVERAGE",
     "test:fix": "yarn lint:fix && ./scripts/test.sh",
-    "test:mocha": "NODE_ENV=test mocha --require ts-node/register.js --require test/setup-chai.ts --require 'test/integration/before.spec.ts' 'test/integration/web3.ts' 'test/**/*.spec.ts'",
-    "test:mocha:coverage": "NODE_ENV=test nyc mocha --require ts-node/register.js --require source-map-support/register --require test/setup-chai.ts --require 'test/integration/before.spec.ts' 'test/integration/web3.ts' 'test/**/*.spec.ts'",
+    "test:mocha": "NODE_ENV=test mocha --require ts-node/register.js --require test/setup-chai.ts --require 'test/integration/before.ts' 'test/integration/web3.ts' 'test/**/*.spec.ts'",
+    "test:mocha:coverage": "NODE_ENV=test nyc mocha --require ts-node/register.js --require source-map-support/register --require test/setup-chai.ts --require 'test/integration/before.ts' 'test/integration/web3.ts' 'test/**/*.spec.ts'",
     "coveralls": "nyc report --reporter=text-lcov | coveralls"
   },
   "main": "./dist/generateTypeChainWrappers.js",

scripts/test.sh

@@ -18,7 +18,7 @@ mkdir $ABI_TMP_DIR
 echo "Generating ABIs for sample contracts"
 ../../../node_modules/.bin/solcjs --abi ./* --bin -o $ABI_DIR
 
-if [ $mode = "COVERAGE" ]; then
+if [ "$mode" = "COVERAGE" ]; then
   yarn test:mocha:coverage
 else
   yarn test:mocha
@@ -28,6 +28,6 @@ echo "Testing if there are no complication problems with generated wrappers"
 yarn tsc
 
 echo "Sending coverage report"
-if [ $mode = "COVERAGE" ]; then
+if [ "$mode" = "COVERAGE" ]; then
   yarn coveralls
 fi

test/integration/before.spec.ts → test/integration/before.ts

@@ -3,6 +3,11 @@ var prepare = require("mocha-prepare");
 import { generateTypeChainWrappers } from "../../lib/generateTypeChainWrappers";
 import { join } from "path";
 
+/**
+ * NOTE: this is done here only to easily count code coverage.
+ * Normally you would run typechain in separate build step, before running your tests.
+ */
+
 prepare(async (done: any) => {
   await generateTypeChainWrappers({
     glob: "**/*.abi",

test/integration/contracts/DumbContract.sol

@@ -8,7 +8,7 @@ contract DumbContract {
   uint public arrayParamLength;
   bytes32 public byteArray;
 
-  function DumbContract() public {
+  constructor() public {
     counter = 0;
     someAddress = msg.sender;
   }