Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Xcode 9.3 & Swift 4.1 #15

Closed
wants to merge 7 commits into from
Closed

Update for Xcode 9.3 & Swift 4.1 #15

wants to merge 7 commits into from

Conversation

tomassliz
Copy link
Collaborator

@tomassliz tomassliz commented Apr 29, 2018

The example project and framework itself were updated to support Xcode 9.3 and Swift 4.1.

I have a two question:

  1. How are supported other platforms - tvOS and macOS. They are both specified in the podspec file but I don't understand, how they are build because the framework itself is set to support iOS only.

  2. Should not be in the Example's Podfile specified the system and its version? Because the example project is iOS only and when pod update is executed, the warning bellow is shown:

[!] Automatically assigning platform ios with version 8.0 on target KZFileWatchers_Example because no platform was specified. Please specify a platform for this target in your Podfile. See https://guides.cocoapods.org/syntax/podfile.html#platform.

I hope that this PR will help.

@tomassliz tomassliz closed this Apr 30, 2018
@tomassliz tomassliz deleted the swift-4.1 branch April 30, 2018 07:57
@krzysztofzablocki
Copy link
Owner

@tomassliz someone just contributed the spec extension for tvOS so I guess it works there via cocoapods, as for the example feel free to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants