Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/callback not on main thread #23

Conversation

SandeepAggarwal
Copy link
Contributor

This PR fixes the following 2 things:

  1. The test cases were not getting compiled due to a linker issue in the Nimble pod
  2. The test cases were getting failed randomly due to concurrent behavior in the RemoteFileWatcher protocol
    It not only fixes the test cases but also the expected behaviour from a networking library to get a callback on the main thread.

Code Changes

The callback was executed on the main thread in Remote.swift
The Podfile was updated to have a post-installation script which fixes the linker issue

@krzysztofzablocki
Copy link
Owner

awesome, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants