Toggle logging of ignored values in class method, not #define #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the issue raised by @andrewsardone in #10, using his proposed solution. Users (CocoaPods users in particular) should now use the class method `+[KZPropertyMapper logIgnoredValues:] to configure whether to log ignored values. The previous method, via `#define KZPropertyMapperLogIgnoredValues`, will still work but is no longer exposed in the public interface. Credit to @andrewsardone for the idea and for suggesting that the class method be placed in a Debug category, to separate it from the class's main concern (that is, mapping stuff).
krzysztofzablocki
pushed a commit
that referenced
this pull request
Sep 3, 2013
Toggle logging of ignored values in class method, not #define
|
Thanks guys! |
|
Thank you, @krzysztofzablocki! Could you add a new version tag so an updated podspec could be added to CocoaPods/Specs? |
|
@andrewsardone: Added tag 1.1, |
andrewsardone
added a commit
to andrewsardone/KZPropertyMapper
that referenced
this pull request
Oct 9, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised by @andrewsardone in #10, using his proposed solution.
Users (CocoaPods users in particular) should now use the class method
+[KZPropertyMapper logIgnoredValues:]to configure whether to log ignored values.The previous method, via
#define KZPropertyMapperLogIgnoredValues, will still work but is no longer exposed in the public interface.Credit to @andrewsardone for the idea and for suggesting that the class method be placed in a Debug category,
to separate it from the class's main concern (that is, mapping stuff).