Adds a way to set non-boolean build settings. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
set_build_settings ({
:'OTHER_CFLAGS' => '-Wall'
})
|
Oh, I forgot: I have not changed the gemspec. So versioning and stuff is for you ;) |
krzysztofzablocki
pushed a commit
that referenced
this pull request
Aug 11, 2014
Adds a way to set non-boolean build settings.
|
Thank you ;) |
|
you're welcome ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As discussed on Twitter, I am here now with the pull request.
I added a way to set non-boolean build settings with Crafter. Although the way via 'options' is somehow redundant, I kept it because Crafter is a library and I don't want to force any user to change their configuration files.
Here is an example how to use it in the config:
set_build_settings ({
:'OTHER_CFLAGS' => '-Wall'
})
I added a few checks too. In case someone wan't use 'options' or 'build_settings' in the config file.
Hope that is all ok with you.
Best,
Stephan