-
Notifications
You must be signed in to change notification settings - Fork 74
Some code is generated even when it's not used #42
Comments
One of the solution to merge natalie.swift would be run script before building it.
|
Two way for Reusable let noReusable = [Reusable]()
let reusables = storyboards.flatMap{
$0.storyboard?.scenes.flatMap{
$0.viewController?.reusables?.filter{
return $0.reuseIdentifier != nil
} ?? noReusable
} ?? noReusable
}
let hasReusable = !reusables.isEmpty yes If we want to develop in separate files and want to concatenate all files in natalies.swift we can use a script like this |
In PR #47
@kostiakoval have you seen other codes to not print ? If none, this issue could be closed after PR #47 merge? (maybe we can discuss about split files elsewhere like in #43) |
Why the whole "ReusableProtocol" is out in this PR ? |
ReusableProtocol describe what is already in UIKit. It's good to have it around with extensions, no matter if Natalie generated something reusable or not. I think this change is unnecessary. |
UICollectionViewController and UITableViewController extension is generated even when they are not used in the application.
The code should be generated only when they are used. It would make code cleaner.
Steps :
The files contains 145 lines of code.
I see 2 improvements:
The text was updated successfully, but these errors were encountered: