Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Natalie breaks when using IBAnimatable #91

Closed
waltermvp opened this issue Mar 15, 2017 · 6 comments
Closed

Natalie breaks when using IBAnimatable #91

waltermvp opened this issue Mar 15, 2017 · 6 comments

Comments

@waltermvp
Copy link

I'm not even sure if a fix is possible since it's caused by a third party dependency. But I get build errors when Natalie generates code for a view controller that is subclassed from AnimatableViewController of IBAnimatable

@krzyzanowskim
Copy link
Owner

what kind of errors? can you make an example project?

@cupojoe
Copy link

cupojoe commented Mar 15, 2017

Here is a blank project with IBAnimatable and Natalie. See if you get the error:
IBAnimatableNatalieError.zip

/Users/cupojoe/Code_Repos/NatalieError/IBAnimatableNatalieError/IBAnimatableNatalieError/Storyboards.swift:239:9: Property 'storyboardIdentifier' must be declared public because it matches a requirement in public protocol 'IdentifiableProtocol'

Edit: please, not this is a local build of Natalie based on master, since the inheritance issue (#78) hasn't made it to the build yet it would seem.

@krzyzanowskim
Copy link
Owner

one more question. do you use master branch, or last release? I should do the release with the latest fixes

@cupojoe
Copy link

cupojoe commented Mar 15, 2017

We are using the release of IBAnimatable (Cocoa Pods) and the master of Natalie, built from source.

@phimage
Copy link
Collaborator

phimage commented May 16, 2017

the code is

output += "extension IdentifiableProtocol where Self: \(customClass) {\n"
if viewController.customModule != nil {
       output += "    var storyboardIdentifier: String? { return \"\(storyboardIdentifier)\" }\n"
} else {
       output += "    public var storyboardIdentifier: String? { return \"\(storyboardIdentifier)\" }\n"
}

customModule is not nil (because of IBAnimatable module is used)

I do not remember why there is this two case

@phimage
Copy link
Collaborator

phimage commented Jun 20, 2018

duplicate of new one with more information #124

@phimage phimage closed this as completed Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants