Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal histogram metrics not being placed in buckets correctly #175

Open
4 tasks
Noah-Huppert opened this issue Jul 22, 2019 · 0 comments
Open
4 tasks
Assignees
Labels
bug Something isn't working

Comments

@Noah-Huppert
Copy link
Contributor

Noah-Huppert commented Jul 22, 2019

The internal duration metrics are not placing entries into buckets correctly. The le label, which is used to specify the bucket, has been set to infinity: le="+Inf".

This isn't very useful b/c most requests are getting put in the infinity bucket.

My initial guess is that using milliseconds is too small of a time unit. Maybe using seconds would work best. The histogram can record float64 values so partial seconds could be published.
My initial guess was wrong. The time.Duration type is actually an int64 representing the duration in nanoseconds. In the code we then divide this by the Millisecond unit. I believe you are supposed to multiply.

Action items:

  • Verify that there is a problem
  • Fix duration unit conversion

Acceptance criteria:

  • (1) The api requests duration metric show multiple buckets with meaningful le values
  • (2) The jobs duration metric show multiple buckets with meaningful le values
@Noah-Huppert Noah-Huppert added the bug Something isn't working label Jul 22, 2019
@Noah-Huppert Noah-Huppert self-assigned this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant