Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sails and Sequelize to peerDependencies #19

Closed
joshrickert opened this issue Mar 31, 2016 · 3 comments
Closed

Add Sails and Sequelize to peerDependencies #19

joshrickert opened this issue Mar 31, 2016 · 3 comments

Comments

@joshrickert
Copy link

Given that this is a "glue" plugin between Sails and Sequelize, it seems like it pretty-well fits the use case for adding those as peer dependencies.

@KSDaemon
Copy link
Owner

KSDaemon commented Oct 5, 2017

Hi @joshrickert! Well... Sequelize is listed in dependencies because this hook will not work without it :)
As for sails — it may be interesting idea, but i think there are some points here: we need to specify peer dependency version. Right now hook supports both v0.12 and v1.0 sails versions. Because npm uses semver, and only one version can be specified, all we can make is to define v0.12 or v1.0 sails version. But that can mislead some developers. So i think we can just ignore it for now :)

@KSDaemon KSDaemon closed this as completed Oct 5, 2017
@joshrickert
Copy link
Author

Appreciate the response! I think the reason I originally opened this was that the module was installing its own, slightly older, version of the libraries mentioned. With the de-duplication features present in the latest versions of npm and yarn, it seems to be less of an issue. It may still be wise to make sure your version requirements are as broad as is practical. Thanks for sharing this plugin with the community, by the way, it's been incredibly helpful.

@KSDaemon
Copy link
Owner

KSDaemon commented Oct 6, 2017

Glad to hear! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants