improve tests

id-ui · Dec 7, 2020 · 9e28b10 · 9e28b10
1 parent dabc9ec
commit 9e28b10
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/__tests__/index.test.js b/src/__tests__/index.test.js
@@ -310,6 +310,14 @@ describe('Popover', () => {
     await waitFor(() =>
       expect(queryByTestId('content')).not.toBeInTheDocument()
     );
+
+    user.click(getByTestId('button'));
+    await waitFor(() => expect(getByTestId('content')).toBeInTheDocument());
+
+    fireEvent.mouseDown(button, { which: 0 });
+    await waitFor(() =>
+        expect(getByTestId('content')).toBeInTheDocument()
+    );
   });
 
   it('closes on escape key press', async () => {
@@ -329,6 +337,24 @@ describe('Popover', () => {
     );
   });
 
+  it('does not close on any button press (except for buttons in props)', async () => {
+    const { getByTestId } = render(
+        <Popover
+            placement="leftBottom"
+            content={<span data-testid="content">Hi!</span>}
+            closeOnEnter
+        >
+          <button data-testid="button">Open</button>
+        </Popover>
+    );
+    user.click(getByTestId('button'));
+    await waitFor(() => expect(getByTestId('content')).toBeInTheDocument());
+    fireEvent.keyDown(document.body, { key: 'Shift', code: 'Shift' });
+    await waitFor(() =>
+        expect(getByTestId('content')).toBeInTheDocument()
+    );
+  });
+
   it('closes on enter key press', async () => {
     const { getByTestId, queryByTestId } = render(
       <Popover

diff --git a/src/components/Popover/hooks/useOpen.js b/src/components/Popover/hooks/useOpen.js
@@ -5,11 +5,11 @@ export default ({
   closeOnEscape,
   closeOnEnter,
   closeOnRemoteClick,
-  onClose = _.noop,
+  onClose,
   isOpen: providedIsOpen = false,
   isOpenControlled,
   onChangeOpen,
-} = {}) => {
+}) => {
   const targetsMap = useRef({});
   const parentNode = useRef(document.body);