Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem about inference service status setting #2012

Closed
631068264 opened this issue Jan 28, 2022 · 1 comment · Fixed by #2016
Closed

A problem about inference service status setting #2012

631068264 opened this issue Jan 28, 2022 · 1 comment · Fixed by #2016
Labels
Projects

Comments

@631068264
Copy link

/kind bug

routeCondition := serviceStatus.GetCondition("ConfigurationsReady")

I‘m not sure is it a bug,but I don't know why to do that

I found this

readyCondition := conditionsMap[component]
ss.SetCondition(readyCondition, serviceCondition)
// propagate route condition for each component
routeCondition := serviceStatus.GetCondition("ConfigurationsReady")
routeConditionType := routeConditionsMap[component]
ss.SetCondition(routeConditionType, routeCondition)
// propagate configuration condition for each component
configurationCondition := serviceStatus.GetCondition("RoutesReady")
configurationConditionType := configurationConditionsMap[component]

Why the value from ConfigurationsReady is assigned to routeCondition , not configurationCondition

Is the variable name wrong, or something else?

Environment:

  • Knative Version: 0.7
@yuzisun
Copy link
Member

yuzisun commented Feb 12, 2022

fixed in #2016

@yuzisun yuzisun added this to To do in KServe 0.8 via automation Feb 12, 2022
@yuzisun yuzisun moved this from To do to Done in KServe 0.8 Feb 12, 2022
@yuzisun yuzisun closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants