Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label and annotation propagation configurable #3710

Open
cmaddalozzo opened this issue May 21, 2024 · 1 comment · May be fixed by #3721
Open

Make label and annotation propagation configurable #3710

cmaddalozzo opened this issue May 21, 2024 · 1 comment · May be fixed by #3721

Comments

@cmaddalozzo
Copy link
Contributor

/kind feature

Describe the solution you'd like
When KServe creates the underlying Knative revisions for an Inference Service's predictor and transformer we propagate the annotations and labels that are attached to the Inference Service. We have a hardcoded disallow list of annotations we do not want to propagate. We should make this list configurable on a cluster level as well as allow configuring a disallow list for labels. We can accomplish this by adding a section to the inferenceservice-config ConfigMap.

     deploy: |-
       {
         "defaultDeploymentMode": "Serverless",
         "serviceAnnotationDisallowedList": [
             "autoscaling.knative.dev/min-scale",
             "autoscaling.knative.dev/max-scale",
             "internal.serving.kserve.io/storage-initializer-sourceuri",
             "kubectl.kubernetes.io/last-applied-configuration"
         ],
         "serviceLabelDisallowedList": []
       }

Before propagating an annotation or label we must ensure it's not present on the respective disallow list.

@terrytangyuan
Copy link
Member

+1

@andyi2it andyi2it linked a pull request Jun 4, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants