Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending HTML emails broken #44

Closed
tomasc opened this issue May 3, 2016 · 8 comments
Closed

Sending HTML emails broken #44

tomasc opened this issue May 3, 2016 · 8 comments

Comments

@tomasc
Copy link
Contributor

tomasc commented May 3, 2016

I ran into an issue when sending emails generated from HTML-only templates (they are being delivered as plain text) and tracked it back to this commit:

2a80783

I will try to make a PR to fix this in coming days.

@tomasc tomasc changed the title Sendings HTML email broken Sending HTML emails broken May 3, 2016
@norbertszivos
Copy link
Contributor

I experienced same problem so upvoting the issue...

@spovich
Copy link
Contributor

spovich commented May 10, 2016

@tomasc or @Sysqa a bugfix PR is welcome.

@kshnurov
Copy link
Owner

@tomasc @Sysqa could you, please, show us a code you're using to send mail?

@norbertszivos
Copy link
Contributor

@kshnurov I'm not using any special things just call the mail function like this

mail(subject: 'notification', to: recipient.email, tags: 'notification', from: REPLY_EMAIL)

and in the view directory we have a html version of the email. After I sent, I got the a text version of the email not the html version.

@tomasc
Copy link
Contributor Author

tomasc commented May 10, 2016

@kshnurov same here, just a standard rails mailer
the only thing is that I don't have a plain text version which trips up the mandrill message (see my link to the commit that imo causes it above)
unfortunately i don't have time to make the pr right now, perhaps next week

@norbertszivos
Copy link
Contributor

@tomasc I created a PR to solve this problem. Do you want to test this code on your system?

@tomasc
Copy link
Contributor Author

tomasc commented Jun 30, 2016

hi @Sysqa and @kshnurov I am back behind the screen. Do you want me to test this, is this released as a new version of the gem? Thanks! Tomas

@spovich
Copy link
Contributor

spovich commented Jun 30, 2016

@tomasc please test. Yes, this is in the 1.3.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants