Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build dependencies #54

Closed
wants to merge 7 commits into from
Closed

Update build dependencies #54

wants to merge 7 commits into from

Conversation

friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented May 11, 2016 •
edited

This updates Gradle wrapper to 2.14.1 and all Android deps to 24. [UPDATE See below: PR now contains more recent dependencies]
[UPDATE 2]
PR now includes latest Gradle wrapper 3.3 and latest Android build tools.

@friederbluemle friederbluemle changed the title Update Gradle wrapper and plug-in Update build dependencies Jun 20, 2016
@friederbluemle
Copy link
Contributor Author

friederbluemle commented Aug 1, 2016 •
edited

Updated to Gradle wrapper 2.14.1 and rebased. Circle CI does not seem to support android-24 yet which is why the build is failing.

@friederbluemle friederbluemle force-pushed the update-project branch 3 times, most recently from 95462df to 02fd593 Compare September 6, 2016 11:07
@friederbluemle
Copy link
Contributor Author

Build is now passing.

@friederbluemle
Copy link
Contributor Author

Updated again to the latest dependencies:

  • Android Gradle plugin 2.2.0
  • Gradle wrapper 3.1

This is now compatible with the latest stable Android Studio 2.2

Also updated minSdkLevel to 9 - This is because of the appcompat-v7 dependency: uses-sdk:minSdkVersion 8 cannot be smaller than version 9 declared in library [com.android.support:appcompat-v7:24.2.1]

@friederbluemle
Copy link
Contributor Author

@kobakei I just rebased this, and it was quite painful, since you coincidentally made many similar changes to the master branch on the same day. The branch now builds again, and contains the remaining fixes and updates.

@kobakei
Copy link
Owner

kobakei commented Feb 7, 2017

Sorry, I have updated SDK version and support lib so I close this PR.

@kobakei kobakei closed this Feb 7, 2017
@friederbluemle
Copy link
Contributor Author

Hmm well you could've just left this PR open, and would have removed the commits with the changes you already made on master. This PR contained more than "just" the SDK version update.

@friederbluemle friederbluemle deleted the update-project branch April 17, 2017 12:27
@friederbluemle friederbluemle mentioned this pull request Apr 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@friederbluemle @kobakei