Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Remove no-op constructors. #38

Closed
hausdorff opened this issue Jun 23, 2017 · 3 comments
Closed

Remove no-op constructors. #38

hausdorff opened this issue Jun 23, 2017 · 3 comments
Labels

Comments

@hausdorff
Copy link
Contributor

Stuff like containerPort.new() is a no-op. Consider just omitting this.

@chuckha
Copy link

chuckha commented Jun 23, 2017

this is not the case with k.extensions.v1beta1.deployment.new() because that yields:

apiVersion: extensions/v1beta1
kind: Deployment

Is there some difference between the two?

@hausdorff
Copy link
Contributor Author

Yes, we want to remove only the no-op constructors. Top-level API objects set kind and apiVersion.

@hausdorff
Copy link
Contributor Author

Actually, we need these right now, because we need the zero value on the lhs for the mixins to work. For example {} + {f+: 3} works, but {f+: 3} does not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants