Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The netkan bot won't pick up multple releases if they are released too close to each other #236

Closed
Ippo343 opened this issue Dec 20, 2014 · 8 comments

Comments

@Ippo343
Copy link
Contributor

Ippo343 commented Dec 20, 2014

The bot refreshes the index about once an hour. However, it seems to assume that only one release has appeared since the last update.

Case study: we missed a FAR release. If you look at the changelog on kerbalstuff, there is a v0.14.4.1 release that hasn't been indexed by the bot. This is because ferram4 has released v0.14.4.1 and v0.14.5 within minutes of each other and the bot only picked up the latest one, ignoring the other one.

Poking @pjf and @AlexanderDzhoganov : we might want to improve the bot's detection of new releases.

@AlexanderDzhoganov
Copy link
Member

This should be in CKAN-netkan, could you move it?

@hakan42
Copy link
Member

hakan42 commented Jan 3, 2015

This issue was moved to KSP-CKAN/CKAN-netkan#23

@hakan42 hakan42 closed this as completed Jan 3, 2015
@pjf
Copy link
Member

pjf commented May 31, 2015

and unmoved. :)

@pjf pjf reopened this May 31, 2015
@Dazpoet
Copy link
Member

Dazpoet commented Jun 6, 2015

I think this is acctually for NetKAN-bot rather than this directory, notifying @techman83 who is either interested enough to open a duplicate over there or close this :)

@techman83
Copy link
Member

I'm hoping KSP-CKAN/NetKAN-bot#2 will help this. Currently NetKAN grabs the latest release and pushes it into CKAN-meta and that only happens every 3 hours currently (due to cpu utilisation).

How common is this situation? What are we missing by missing a release if a new one was released soon after (presumably it would most commonly done to fix a futzed release?).

@Dazpoet
Copy link
Member

Dazpoet commented Jun 7, 2015

Not sure how big of a problem this really is acctually, I can't say I've ever ran into a problem because of this.

For the completionist in all of us it would be nice to have an as complete repository as possible though which should include all versions, no matter how insignificant.

@plague006
Copy link
Contributor

@techman83 if this can't be (reasonably) fixed, can we close the issue?

@techman83
Copy link
Member

@plague006 generally if releases are really close together it probably means a bug and we'll likely miss the buggy one. So it's probably pretty edge case.

There is room in the code for more frequent indexing and we'll get there eventually. So I think yes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants