Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the NuGet libraries in release mode #12

Closed
calebkiage opened this issue Mar 8, 2016 · 7 comments
Closed

Build the NuGet libraries in release mode #12

calebkiage opened this issue Mar 8, 2016 · 7 comments
Assignees

Comments

@calebkiage
Copy link

The NuGet dlls can't be used on windows store apps because they are built in debug mode. I had an application I was publishing fail certification because of this. It passed after I built the dlls from source in release mode and replaced the NuGet dlls.

@kswoll kswoll added the bug label Mar 8, 2016
@kswoll kswoll self-assigned this Mar 8, 2016
@kswoll
Copy link
Owner

kswoll commented Mar 8, 2016

Wow, I hadn't realized that Release mode would impact such a scenario. Thanks for the report! Latest nuget should fix that. (might take a few minutes for it to propagate on their servers, but the version would be ReactiveUI.Fody 1.1.25.

@kswoll kswoll closed this as completed Mar 8, 2016
@kswoll kswoll added the fixed label Mar 8, 2016
@calebkiage
Copy link
Author

I have tried to update the package but it's removing the reference to ReactiveUI.Fody.Helpers from the project. Version 1.1.10 works properly.

@calebkiage
Copy link
Author

Adding the reference manually, Fody throws the error:

Fody: Could not find a weaver named 'ReactiveUI'. 
If you have nuget package restore turned on you probably need to do a build to download the weavers. 
Alternatively you may have added a weaver to your 'FodyWeavers.xml' and forgot to add the appropriate nuget package.
Perhaps you need to run 'Install-Package ReactiveUI.Fody'. This url may provide more information http://nuget.org/packages/ReactiveUI.Fody/

@kswoll
Copy link
Owner

kswoll commented Mar 8, 2016

Hmm, sorry about that. I see what you are saying and can repro locally. I'll fix.

@calebkiage
Copy link
Author

Ah, great! Thank you for the timely responses.

@kswoll
Copy link
Owner

kswoll commented Mar 8, 2016

Ok, all set. I've tested the latest version on a sample project and it works fine now.

I apologize for not testing my change first -- I recently had to recreate my deployment script for appveyor and I evidently screwed up the nuget package process.

@calebkiage
Copy link
Author

That's alright. Happens to the best of us. The new package version works fine now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants