Found a funky edge case with decodeURIComponent returning + for + and…

… for %2B
ksykulev · Feb 1, 2013 · dd337ff · dd337ff
1 parent 0684ae9
commit dd337ff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/objektivity.js b/objektivity.js
@@ -10,7 +10,7 @@
 
     var unescape = function(s){
       if(!s){ return s; }
-      return decodeURIComponent(s).replace(/\+/g, ' ');
+      return decodeURIComponent(s.replace(/\+/g, '%20'));
     }
 
     var parseQuery = function(queryString, d){

diff --git a/test/objektivity_spec.js b/test/objektivity_spec.js
@@ -9,6 +9,9 @@ describe("objektivity_spec", function(){
     it("should unespace %20", function(){
       expect(objektivity.unescape('a%20space')).toEqual('a space');
     });
+    it("should unescape %2B", function(){
+      expect(objektivity.unescape('a%2Bspace')).toEqual('a+space');
+    });
     it("should unespace a URI escaped string", function(){
       expect(objektivity.unescape('q1%212%22%27w%245%267%2Fz8%29%3F%5C')).toEqual("q1!2\"'w$5&7/z8)?\\");
     });