Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images for release 0.4.0 missing on dockerhub #323

Closed
markus512 opened this issue Nov 13, 2019 · 4 comments
Closed

Images for release 0.4.0 missing on dockerhub #323

markus512 opened this issue Nov 13, 2019 · 4 comments

Comments

@markus512
Copy link

Tried to install release 0.4.0 onto my kubernetes cluster.

Pods don't start because tag 0.4.0 is missing in vaporio/ksync on dockerhub.

I replaced the image with ksync/ksync:git-11c5444 which seems to work fine but it would be great if it is possible to upload that tag and make release 0.4.0 working as is.

@grampelberg
Copy link
Collaborator

How are you running 0.4? I just double checked and it is using ksync/ksync:git-dcb80e9 by default.

@markus512
Copy link
Author

markus512 commented Nov 13, 2019

I tried to install it from jenkins x using jx sync. Will try to debug that tomorrow. Manual installation indeed works as usual and uses ksync/ksync:git-dcb80e9.

Edit: I just found the cause in https://github.com/jenkins-x/jx/blob/7335c1680bdb98c3294d0107eba02d04842e32ba/pkg/cmd/sync/sync.go

Version was manually specified there on line 120:
// Deal with #218
err = o.RunCommandInteractive(true, "ksync", "init", "--upgrade", "--image",
fmt.Sprintf("vaporio/ksync:%s", version))

@markus512
Copy link
Author

I'll close this issue now as there is nothing wrong in ksync itself.
@grampelberg Thank you for taking the time to deal with my issue.

@grampelberg
Copy link
Collaborator

You bet! Sorry about the extra overhead there from the org change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants