-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_getJsonPath function doesn't allow query strings #19
Comments
I'm having the same issue as solyoung. I wanted to use the query options but as you hard code the auth variable as the only query param available you make it impossible to use this without modification. I know it's a very simple wrapper but a more dynamic params approach would be ideal. |
Thank you for your suggestion, this is a very important feature. I marked it as a todo. |
I would love to see this feature as well. Then we can use shallow copy and other query options. |
Here's a suggestion that would allow query functionality to get through that function (it's how I have the code modified in the meantime): *note, if you use the above, you need to include .json in your original request. e.g. $firebaseLib->get('test.json?orderBy=email'); If you don't include .json, the above will still append .json at the end of that path. |
I modified the firebaseLib.php file with the following lines to add some query functionality: } |
Query parameters are supported in version v2.1.0 https://github.com/ktamas77/firebase-php/releases/tag/v2.1.0 |
The Firebase API offers orderBy and advanced query options. The _getJsonPath function currently appends ".json" to the end of the path without regard to the $path. This should be corrected so that query strings can be passed in the $path.
I may fork and solve, but at least wanted the issue reported in case I don't get back here.
The text was updated successfully, but these errors were encountered: