Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling assert() with a string argument is deprecated in PHP 7.2 #27

Open
kevaschmim opened this issue May 2, 2018 · 1 comment
Open

Comments

@kevaschmim
Copy link

We have been using this plugin for some time now and upgraded our Wordpress sites to the latest version, and also upgraded PHP in these instances to the latest version, but started getting this error:

Deprecated: assert(): Calling assert() with a string argument is deprecated in /var/www/html/wp-content/plugins/saml/saml/lib/SimpleSAML/Auth/Simple.php on line 25

The error also comes up in many more files when we try to log in, this is just the one that makes it to the front page.

Are there any plans to update this plugin to handle this?

@Promaethius
Copy link

Promaethius commented Nov 20, 2018

@kevaschmim note that this plugin uses an upstream version of SimpleSAMLPHP from https://github.com/simplesamlphp/simplesamlphp
https://simplesamlphp.org/archive indicates there are no major API changes over the last two years so you should be able to simply overwrite the saml directory with the root of simplesamlphp.
https://simplesamlphp.org/docs/1.16/simplesamlphp-changelog#section_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants