Cisco XR commit failure handling not working properly

[tdorssers]

The commit command is an interactive command and the code tries to handle the situation where other commits have occurred during the configuration session. However send_command_expect is used instead of send_command_timing and therefore the code to handle the alt_error_marker is never reached.
I propose to change output += self.send_command_expect( into output += self.send_command_timing( of the following section of cisco_xr.py.

        # Enter config mode (if necessary)
        output = self.config_mode()
        output += self.send_command_expect(
            command_string,
            strip_prompt=False,
            strip_command=False,
            delay_factor=delay_factor,
        )
        if error_marker in output:
            raise ValueError(f"Commit failed with the following errors:\n\n{output}")
        if alt_error_marker in output:
            # Other commits occurred, don't proceed with commit
            output += self.send_command_timing(
                "no", strip_prompt=False, strip_command=False, delay_factor=delay_factor
            )
            raise ValueError(f"Commit failed with the following errors:\n\n{output}")

Before the proposed change, netmiko incorrectly raises NetmikoTimeoutException with message Timed-out reading channel, pattern not found in output. After the proposed change, netmiko correctly raises ValueError with message Commit failed with the following errors:.
Thanks,
Tim

[ktbyers]

We should also add a test case for this into our IOS-XR tests. I am probably only testing the normal case where there are no other pending commits (I am assuming this is why my standard commit tests on IOS-XR are working properly).

[tdorssers]

It looks like test_clear_msg() in test_netmiko_commit.py ends with assert True is True, so the test case always succeeds if I am not mistaken.

[ktbyers]

Yes, it looks to me like that test was never fully implemented.