Add Hillstone device type #3068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR superseded by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,ktbyer,
please review and consider this PR to enable support for hillstone (https://www.hillstonenet.com/)
Support for:
SSH
send commands
save config
I had run tests for ssh connection.
show and config and save config Test run output bellow,
PS D:\netmiko\tests> py.test -v test_netmiko_show.py --test_device hillstone
============================================================================================================================ test session starts ============================================================================================================================
platform win32 -- Python 3.8.0, pytest-7.2.0, pluggy-1.0.0 -- d:\python38\python.exe
cachedir: .pytest_cache
rootdir: D:\netmiko, configfile: setup.cfg
collected 25 items
test_netmiko_show.py::test_failed_key SKIPPED (Not using SSH-keys) [ 4%]
test_netmiko_show.py::test_disable_paging PASSED [ 8%]
test_netmiko_show.py::test_terminal_width PASSED [ 12%]
test_netmiko_show.py::test_ssh_connect PASSED [ 16%]
test_netmiko_show.py::test_ssh_connect_cm PASSED [ 20%]
test_netmiko_show.py::test_send_command_timing PASSED [ 24%]
test_netmiko_show.py::test_send_command_timing_no_cmd_verify SKIPPED [ 28%]
test_netmiko_show.py::test_send_command PASSED [ 32%]
test_netmiko_show.py::test_send_command_no_cmd_verify SKIPPED [ 36%]
test_netmiko_show.py::test_complete_on_space_disabled SKIPPED [ 40%]
test_netmiko_show.py::test_send_command_textfsm SKIPPED (TextFSM/ntc-templates not supported on this platform) [ 44%]
test_netmiko_show.py::test_send_command_ttp SKIPPED (TTP template not existing for this platform) [ 48%]
test_netmiko_show.py::test_send_command_genie SKIPPED (Genie not supported on this platform) [ 52%]
test_netmiko_show.py::test_send_multiline_timing SKIPPED [ 56%]
test_netmiko_show.py::test_send_multiline SKIPPED [ 60%]
test_netmiko_show.py::test_send_multiline_prompt SKIPPED [ 64%]
test_netmiko_show.py::test_send_multiline_simple SKIPPED [ 68%]
test_netmiko_show.py::test_base_prompt PASSED [ 72%]
test_netmiko_show.py::test_strip_prompt PASSED [ 76%]
test_netmiko_show.py::test_strip_command PASSED [ 80%]
test_netmiko_show.py::test_normalize_linefeeds PASSED [ 84%]
test_netmiko_show.py::test_clear_buffer PASSED [ 88%]
test_netmiko_show.py::test_enable_mode PASSED [ 92%]
test_netmiko_show.py::test_disconnect PASSED [ 96%]
test_netmiko_show.py::test_disconnect_no_enable SKIPPED [100%]
========================================================================================================================== short test summary info ==========================================================================================================================
SKIPPED [1] test_netmiko_show.py:25: Not using SSH-keys
SKIPPED [1] test_netmiko_show.py:88: Skipped
SKIPPED [1] test_netmiko_show.py:106: Skipped
SKIPPED [1] test_netmiko_show.py:128: Skipped
SKIPPED [1] test_netmiko_show.py:149: TextFSM/ntc-templates not supported on this platform
SKIPPED [1] test_netmiko_show.py:171: TTP template not existing for this platform
SKIPPED [1] test_netmiko_show.py:211: Genie not supported on this platform
SKIPPED [1] test_netmiko_show.py:231: Skipped
SKIPPED [1] test_netmiko_show.py:247: Skipped
SKIPPED [1] test_netmiko_show.py:272: Skipped
SKIPPED [1] test_netmiko_show.py:296: Skipped
SKIPPED [1] test_netmiko_show.py:401: Skipped
====================================================================================================================== 13 passed, 12 skipped in 19.74s ======================================================================================================================
PS D:\netmiko\tests> py.test -v test_netmiko_config.py --test_device hillstone
============================================================================================================================ test session starts ============================================================================================================================
platform win32 -- Python 3.8.0, pytest-7.2.0, pluggy-1.0.0 -- d:\python38\python.exe
cachedir: .pytest_cache
rootdir: D:\netmiko, configfile: setup.cfg
collected 13 items
test_netmiko_config.py::test_ssh_connect PASSED [ 7%]
test_netmiko_config.py::test_enable_mode PASSED [ 15%]
test_netmiko_config.py::test_config_mode PASSED [ 23%]
test_netmiko_config.py::test_exit_config_mode PASSED [ 30%]
test_netmiko_config.py::test_config_set PASSED [ 38%]
test_netmiko_config.py::test_config_set_generator PASSED [ 46%]
test_netmiko_config.py::test_config_set_longcommand PASSED [ 53%]
test_netmiko_config.py::test_config_hostname PASSED [ 61%]
test_netmiko_config.py::test_config_from_file SKIPPED [ 69%]
test_netmiko_config.py::test_config_error_pattern SKIPPED (No error_pattern defined.) [ 76%]
test_netmiko_config.py::test_banner SKIPPED (No banner defined.) [ 84%]
test_netmiko_config.py::test_global_cmd_verify SKIPPED (No banner defined.) [ 92%]
test_netmiko_config.py::test_disconnect PASSED [100%]
========================================================================================================================== short test summary info ==========================================================================================================================
SKIPPED [1] test_netmiko_config.py:163: Skipped
SKIPPED [1] test_netmiko_config.py:175: No error_pattern defined.
SKIPPED [1] test_netmiko_config.py:209: No banner defined.
SKIPPED [1] test_netmiko_config.py:242: No banner defined.
======================================================================================================================= 9 passed, 4 skipped in 5.87s ========================================================================================================================
PS D:\netmiko\tests> py.test -v test_netmiko_save.py --test_device hillstone
============================================================================================================================ test session starts ============================================================================================================================
platform win32 -- Python 3.8.0, pytest-7.2.0, pluggy-1.0.0 -- d:\python38\python.exe
cachedir: .pytest_cache
rootdir: D:\netmiko, configfile: setup.cfg
collected 2 items
test_netmiko_save.py::test_save_base PASSED [ 50%]
test_netmiko_save.py::test_disconnect PASSED [100%]
============================================================================================================================= 2 passed in 7.28s =============================================================================================================================
PS D:\netmiko\tests>