Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a image title or data to the a tag #31

Open
dinc5150 opened this issue Jan 24, 2017 · 2 comments
Open

Adding a image title or data to the a tag #31

dinc5150 opened this issue Jan 24, 2017 · 2 comments

Comments

@dinc5150
Copy link

Hi,

I need to show a title of the selected image when any of the images are clicked. I tried adding a data attribute to the anchor tag, but it gets lost when the transferred into the smooth Products component.

So a couple of possible feature requests:

  • Allow the display of a title above/below the main image for the selected image
  • Allow adding extra attributes to the anchor (like the "data-" attribute
  • Adding an OnImageSelected callback to allow for custom JS calls

I'f I get the chance to do a proper implementation, I'll submit a pull request, but swamped at the moment, so I might have to just implement a workaround.

@aztekweb
Copy link

@dinc5150 Did you get a chance to implement this?

@dinc5150
Copy link
Author

Sorry @aztekweb, I never implemented the feature as the client was happy to work around the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant