Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentType should be MimeType #1315

Open
saschpe opened this issue Sep 3, 2019 · 3 comments
Open

ContentType should be MimeType #1315

saschpe opened this issue Sep 3, 2019 · 3 comments
Labels

Comments

@saschpe
Copy link
Contributor

saschpe commented Sep 3, 2019

Is your feature request related to a problem? Please describe.
HTTP does not know about a content type, it's all about MIME types. Others than the "Content-Type:" HTTP header, the "Accept:" header takes a MIME type as well. It's a little confusing when using ContentType.Application.Json instead of MimeType.Application.Json

Describe the solution you'd like
Rename ContentType to MimeType

@e5l
Copy link
Member

e5l commented Sep 4, 2019

Hi @saschpe, thanks for the report. We could introduce type alias at least.

@saschpe
Copy link
Contributor Author

saschpe commented Sep 4, 2019

That would make sense to avoid an API break. One way would be to rename, add a compat typealias with maybe a deprecation warning..

@oleg-larshin
Copy link

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants