Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations: Support trailing / #25

Closed
mathiasbn opened this issue Jul 8, 2016 · 4 comments
Closed

Locations: Support trailing / #25

mathiasbn opened this issue Jul 8, 2016 · 4 comments
Labels

Comments

@mathiasbn
Copy link

At the moment you cannot create hrefs from a location with trailing /:
/somepath/ as it would end up being /somepath

This should of cause also work for nested Locations, so i could do:

@location("/somepath/") class SomeLocation{
    @location("/nested/") class Nested
}

and get /somepath/and /somepath/nested/

@gzoritchak
Copy link

gzoritchak commented Jul 15, 2016

I agree. Having the trailing / or not is considered as two different urls. It could serve (even if it is not recommended) 2 different contents.
http://webmasters.stackexchange.com/questions/68721/in-terms-of-seo-what-is-the-difference-between-a-url-with-and-without-a-trailin

I have the same problem as @mathiasbn. An older website I plan to migrate have urls with the trailing /. It would be easier to do the migration with locations managing it.

@stale
Copy link

stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the stale label Sep 24, 2019
@hhariri
Copy link
Contributor

hhariri commented Jul 21, 2020

For follow-ups to this issue, please see https://youtrack.jetbrains.com/issue/KTOR-836

@hhariri hhariri closed this as completed Jul 21, 2020
@oleg-larshin
Copy link

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants