ReaderJob & WriterJob leak in TLS socket and prevent context from completion

[olehs]

ktor/ktor-network/ktor-network-tls/jvm/src/io/ktor/network/tls/TLSClientSessionJvm.kt

Lines 40 to 48 in 0081f94

	override fun attachForReading(channel: ByteChannel): WriterJob =
	writer(coroutineContext + CoroutineName("cio-tls-input-loop"), channel) {
	appDataInputLoop(this.channel)
	}
	override fun attachForWriting(channel: ByteChannel): ReaderJob =
	reader(coroutineContext + CoroutineName("cio-tls-output-loop"), channel) {
	appDataOutputLoop(this.channel)
	}

Jobs created by these two methods should be cancelled when socket is closed

[Nek-12]

I don't know how did you manage to create an issue here since new issues lead to JetBrains issuetracker, but I think you should move it there

[rmmcosta]

Does this issue still makes sense after the #3690 fix?

[olehs]

I didn't track latest changes as we used a workaround (see below), so can't say for sure. I'll check it and if any issues appear, report them in a new topic.

    private class TLSSocket(private val tlsSocket: Socket) : Socket by tlsSocket {
        private var readerJob: ReaderJob? = null
        private var writerJob: WriterJob? = null

        override fun attachForReading(channel: ByteChannel): WriterJob {
            return tlsSocket.attachForReading(channel).also {
                writerJob = it
            }
        }

        override fun attachForWriting(channel: ByteChannel): ReaderJob {
            return tlsSocket.attachForWriting(channel).also {
                readerJob = it
            }
        }

        override fun close() {
            readerJob?.cancel()
            writerJob?.cancel()
        }
    }

Thank you