Fix for #204 #210
Merged
Fix for #204 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSnoozer
pushed a commit
that referenced
this pull request
Jul 12, 2015
Fix for #204: added the ability to set the timezone along with dateFormat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #204 added the ability to set the timezone along with dateFormat.
I hopefully made it crystal clear in the docs that setting the timeZone in the plugin's configuration will override any other configuration.
The reason for this, is that we can not determine at which level the user has altered the timezone of java or the system. It could be in some configuration file or by setting runtime environment parameters like
-Duser.timezone=UTC. If we investigate the system properties of java, we only see the latest version that was set. At this moment java does not simply ship an option to determine where the timezone was altered. Also I didn't want to introduce some garbage code that invokes a process builder that asks for thereal timezone(or some other magic code that is system dependant).