Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key mappings for inputting #52

Closed
ktr0731 opened this issue May 12, 2018 · 1 comment
Closed

key mappings for inputting #52

ktr0731 opened this issue May 12, 2018 · 1 comment

Comments

@ktr0731
Copy link
Owner

ktr0731 commented May 12, 2018

Problem

Evans uses c-bata/go-prompt as the input method in REPL mode.
c-bata/go-prompt doesn't return C-d (io.EOF), only returns empty string.
so, Evans cannot determine whether empty input is C-d or just entered.
therefore, currently, Evans doesn't use C-d to notify end of input.

Currently key mappings

mapping result
enter inputs default value (in repeated fields, this mapping is disabled.)
enter + enter terminates inputting repeated fields

New key mappings for new features

I planning streaming modes.
for these features, I will introduce new key mappings to terminate stream.

mapping result
C-c terminates each streaming mode

also to fix behavior of enter mapping in repeated fields, I considering abolish enter + enter mapping.
instead of the mapping, C-c mapping terminates repeated fields inputting.

if you have any idea, please tell me.

thanks.

Note

the final mapping table is:

mapping result
enter inputs default value
C-c terminates each mode (if current field is not repeated fields)
C-c terminates inputting repeated fields

if you want to terminate streaming mode in repeated fields inputting, you need to input C-c two times.

@mitramejia
Copy link

mitramejia commented Oct 31, 2018

I had to go to the issues to know the keymap to end repeating inputs, it would be good to move this to README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants