fix: handle attribute selectors having double quotes in their value c…

…orrectly
ktsn · May 5, 2018 · 5f2e950 · 5f2e950
1 parent 68be320
commit 5f2e950
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/parser/style/codegen.ts b/src/parser/style/codegen.ts
@@ -76,7 +76,10 @@ export function genSelector(s: t.Selector): string {
     const attrsCodes = s.attributes.map(attr => {
       if (attr.operator != null && attr.value != null) {
         const suffix = attr.insensitive ? ' i' : ''
-        return `[${attr.name}${attr.operator}"${attr.value}"${suffix}]`
+        const quote = attr.value.includes('"') ? "'" : '"'
+        return `[${attr.name}${attr.operator}${quote}${
+          attr.value
+        }${quote}${suffix}]`
       } else {
         return `[${attr.name}]`
       }

diff --git a/test/parser/style/codegen.spec.ts b/test/parser/style/codegen.spec.ts
@@ -164,4 +164,17 @@ describe('Style codegen', () => {
 
     expect(genStyle(ast)).toBe(expected)
   })
+
+  it('uses single quote for attribute value when it has double quote', () => {
+    const ast = createStyle([
+      rule([
+        selector({
+          attributes: [attribute('value', '=', '"quoted"')]
+        })
+      ])
+    ])
+    const expected = '[value=\'"quoted"\'] {}'
+
+    expect(genStyle(ast)).toBe(expected)
+  })
 })