feat: enable to zoom viewport with pinch #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Included #24. It is almost implemented but there is still a bug which the renderer scrolling content is unexpectedly larger than expected size. |
This looks like Chromium bug. Safari and Firefox don't occur this problem. |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 65.13% 65.06% -0.08%
==========================================
Files 44 44
Lines 1394 1414 +20
Branches 327 329 +2
==========================================
+ Hits 908 920 +12
- Misses 471 479 +8
Partials 15 15
Continue to review full report at Codecov.
|
ktsn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to zoom the viewport scale by trackpad pinchin / pinchout. It also adds a scale input on toolbar which works as same as size field on the toolbar.
To detect the user pinches a trackpad, we can use
wheelevent with ctrl key is pressed.https://medium.com/@auchenberg/detecting-multi-touch-trackpad-gestures-in-javascript-a2505babb10e
We also need to improve scrolling renderer area (#20). Currently, when it is zoomed in larger than viewport, we cannot see the top of the viewport.